Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add minor tweaks to migration guide 1/3 #1763

Merged

Conversation

peter-csala
Copy link
Contributor

Pull Request

The issue or feature being addressed

  • Part 1: Review from Migrating execution policies till Migrating timeout policies
  • Part 2: Add missing Migrating circuit breaker policies
  • Part 3: Review from Migrating other policies till Interoperability between policies and resilience pipelines

Details on the issue fix or feature implementation

  • Migrating execution policies
    • Reordered the interface list to align with code samples
    • Added line breaks to the V7's non-generic examples to have the same look and feel as the generic ones
    • Renamed the Execute{Async}'s CancellationToken parameter to token to avoid ambiguity
    • Renamed lambda function's r parameter to result to align with V8's sample
    • In case of V8 used static anonymous function whenever it is possible
    • Added important section at the end as a TL;DR + link for further info
  • Migrating policy wrap
    • Added important section at the end as a TL;DR + link for further info
  • Migrating retry policies
    • Fixed V7's code examples indentations
    • Moved and fixed the V7's Retry forever example
    • In case of V8 used static anonymous function whenever it is possible
    • Added important section at the end as a TL;DR + link for further info
  • Migrating rate limit policies
    • Added important section at the end as a TL;DR + link for further info
  • Migrating bulkhead policies
    • Fixed V7's code examples indentations to align with rate limiter examples
    • Added important section at the end as a TL;DR + link for further info
  • Migrating timeout policies
    • Added important section at the end as a TL;DR + link for further info

Preview

Confirm the following

  • I started this PR by branching from the head of the default branch
  • I have targeted the PR to merge into the default branch
  • I have included unit tests for the issue/feature
  • I have successfully run a local build

@codecov
Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e404873) 84.53% compared to head (aa05cd7) 84.53%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1763   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files         307      307           
  Lines        6777     6777           
  Branches     1043     1043           
=======================================
  Hits         5729     5729           
  Misses        839      839           
  Partials      209      209           
Flag Coverage Δ
linux 84.53% <ø> (ø)
macos 84.53% <ø> (ø)
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
docs/migration-v8.md Outdated Show resolved Hide resolved
@martincostello martincostello enabled auto-merge (squash) October 31, 2023 15:21
@martincostello martincostello merged commit 9ff0986 into App-vNext:main Oct 31, 2023
14 checks passed
@peter-csala peter-csala deleted the add-minor-tweaks-to-migration-guide branch October 31, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants