Annotate the library with trimming attributes #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1414 +/- ##
==========================================
+ Coverage 83.81% 83.83% +0.02%
==========================================
Files 274 274
Lines 6482 6491 +9
Branches 1009 1008 -1
==========================================
+ Hits 5433 5442 +9
Misses 840 840
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
martincostello
approved these changes
Jul 19, 2023
| @@ -1,7 +1,6 @@ | |||
| using System.ComponentModel; | |||
|
|
|||
| using System.ComponentModel.DataAnnotations; | |||
|
|
|||
There was a problem hiding this comment.
Did you mean to delete the line above rather than below?
martincostello
added a commit
to martincostello/Polly
that referenced
this pull request
Jul 20, 2023
Some minor updates to the trimming annotations added in App-vNext#1414.
martincostello
added a commit
that referenced
this pull request
Jul 20, 2023
Some minor updates to the trimming annotations added in #1414.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details on the issue fix or feature implementation
Use trimming attributes and resolve the trimming warnings. With this change the AOT compilation works correctly (including the options validation).
Closes #1110
Confirm the following