Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Py3 support and not support PEP8? #16

Closed
Allianzcortex opened this issue Jul 5, 2017 · 2 comments
Closed

No Py3 support and not support PEP8? #16

Allianzcortex opened this issue Jul 5, 2017 · 2 comments
Labels
Type: Question Indicates that an issue or pull request needs more information

Comments

@Allianzcortex
Copy link

e.g.:https://github.com/ApolloAuto/apollo/blob/master/modules/tools/control_info/control_info.py

1.use print "Showing Lateral" rather than print ("Showing Lateral");I expect many from __future__ import xx lines

2.And import order:import sys is system library,appear on first line;import threading is also system library,appear on second line from bottom;including third-part library and module-part library between them;I don't konw whcih coding-style support such writing?

@xiaoxq
Copy link
Contributor

xiaoxq commented Jul 5, 2017

Thanks for the advice.

  1. We stick to py2 currently.
  2. We will do the code clean ASAP. Or you may also help on it :)

@Allianzcortex
Copy link
Author

@xiaoxq
for the 1st issue,it's a pity/(ㄒoㄒ)/~~ mainly because I don't find some gevent-like-python2-only-library in use,so I just think compatibility with python3 won't be very difficult?(⊙﹏⊙) even Tensorflow supports both version,so......~~
and the 2nd,thanks for your appreciation~~Now I'll try to see how C++ code is writen,Python is just a wrapper and plot toolkit :)

@jinghaomiao jinghaomiao added the Type: Question Indicates that an issue or pull request needs more information label Jul 24, 2017
GowthamKudupudi pushed a commit to amd/apollo that referenced this issue Nov 17, 2022
[HIPIFY][planning] Add missing hipification of cuda_runtime.h include (on behalf emankov)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Question Indicates that an issue or pull request needs more information
Projects
None yet
Development

No branches or pull requests

3 participants