refactor(access_identity): Fix varaibles to enable access identity

Aplyca · Jul 30, 2018 · c694cb3 · c694cb3
1 parent 5c822f1
commit c694cb3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -1,4 +1,4 @@
 Terraform AWS S3 module
 ========================
 
-Create a AWS S3 bickets optimized for static web hosting
+Create a AWS S3 buckets optimized for static web hosting
diff --git a/data.tf b/data.tf
@@ -1,5 +1,5 @@
 data "aws_iam_policy_document" "access_identity" {
-  count = "${var.access_identity_arn != "" ? 1 : 0}"
+  count = "${var.access_identity ? 1 : 0}"
   statement {
     actions   = ["s3:GetObject"]
     resources = ["arn:aws:s3:::$${bucket_name}$${origin_path}*"]
@@ -22,7 +22,7 @@ data "aws_iam_policy_document" "access_identity" {
 }
 
 data "template_file" "access_identity" {
-  count = "${var.access_identity_arn != "" ? 1 : 0}"
+  count = "${var.access_identity ? 1 : 0}"
   template = "${data.aws_iam_policy_document.access_identity.json}"
 
   vars {

diff --git a/main.tf b/main.tf
@@ -19,7 +19,7 @@ resource "aws_s3_bucket" "this" {
 }
 
 resource "aws_s3_bucket_policy" "access_identity" {
-  count = "${var.access_identity_arn != "" ? 1 : 0}"
+  count = "${var.access_identity ? 1 : 0}"
   bucket = "${aws_s3_bucket.this.id}"
   policy = "${data.template_file.access_identity.rendered}"
 }

diff --git a/variables.tf b/variables.tf
@@ -41,6 +41,10 @@ variable "access_identity_arn" {
   default = ""
 }
 
+variable "access_identity" {
+  default = false
+}
+
 variable "read_permissions" {
   default = [
     "s3:GetObject"