Initial usage of the typescript-sdk
#4762
Conversation
|
Thank you for creating a pull request! Pinging @EricWittmann to respond or triage. |
Yes.
Let's get this PR merged first, then I'll convert everything else in a single followup PR.
I'll delete all the existing models in favor of the Kiota generated ones.
LGTM, although it's a bit hard to review |
I told you I'm bad at formatting code 😛 it's probably copy pasted. |
| @@ -20,5 +20,8 @@ | |||
| "devDependencies": { | |||
| "rimraf": "5.0.7", | |||
| "shelljs": "0.8.5" | |||
| }, | |||
| "dependencies": { | |||
| "@apicurio/apicurio-registry-client": "file:../typescript-sdk" | |||
There was a problem hiding this comment.
this uses npm link ... not sure if we can improve it anyhow ...
There was a problem hiding this comment.
ok - i'll see what I can do on this
|
|
||
|
|
||
| const AXIOS = axios.create(); |
There was a problem hiding this comment.
Ideally, at the end of the process, the rest of this file should go away.
|
|
||
| export function createAuthProvider(auth: AuthService): AuthenticationProvider { | ||
| if (auth.isOidcAuthEnabled()) { | ||
| return new TokenAuthenticationProvider("Bearer", async () => auth.getToken().then(v => v!)); |
There was a problem hiding this comment.
Just to be sure, are we testing those configurations of the UI in CI?
There was a problem hiding this comment.
What configurations? We're only doing basic testing of the UI in CI - in two places. We have UI tests in the registry repo, and we have some in the 3scale dev environment as well.
More UI testing is for sure needed - currents tests are mostly smoke tests.
There was a problem hiding this comment.
Do we test the UI in an environment where OIDC is enables and Keycloak configured?
There was a problem hiding this comment.
In the 3scale dev environment, yes. But not in registry CI.
andreaTP
changed the title
typescript-sdktypescript-sdk
|
I hope I have addressed all the comments, a couple of additional questions 🙂 :
|
I'm just getting to this now, but for sure we do not want to commit the generated code. And this PR doesn't seem to do that...which is good.
We could optimize I guess - only generate if the |
I was mistaken due to the LOC changed 😅 .
No, I think it's fine with this proposed setup. |
|
Closing in favor of #4806 |
Based on #4338
I updated everything on the Kiota side and converted one simple endpoint to use the TS SDK in the UI.
models should we use as a source of truth?