Merge pull request eclipse-iceoryx#1472 from ApexAI/iox-#1196-fix-var…

…iant-queue-warnings iox-eclipse-iceoryx#1196 Fix warnings in VariantQueue
ApexAI · Jul 11, 2022 · d5be6d8 · d5be6d8
2 parents d31baa7 + eb282e4
commit d5be6d8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/iceoryx_hoofs/include/iceoryx_hoofs/cxx/variant_queue.hpp b/iceoryx_hoofs/include/iceoryx_hoofs/cxx/variant_queue.hpp
@@ -77,7 +77,7 @@ class VariantQueue
 
     /// @brief Constructor of a VariantQueue
     /// @param[in] type type of the underlying queue
-    VariantQueue(const VariantQueueTypes type) noexcept;
+    explicit VariantQueue(const VariantQueueTypes type) noexcept;
 
     /// @brief pushs an element into the fifo
     /// @param[in] value value which should be added in the fifo

diff --git a/iceoryx_hoofs/test/moduletests/test_cxx_variant_queue.cpp b/iceoryx_hoofs/test/moduletests/test_cxx_variant_queue.cpp
@@ -28,17 +28,19 @@ using namespace iox::cxx;
 class VariantQueue_test : public Test
 {
   public:
-    void SetUp()
+    void SetUp() override
     {
     }
-    void TearDown()
+    void TearDown() override
     {
     }
 
-    void PerformTestForQueueTypes(const std::function<void(uint64_t typeID)>& testCase) noexcept
+    void PerformTestForQueueTypes(const std::function<void(uint64_t typeID)>& testCase) const noexcept
     {
         for (uint64_t i = 0; i < numberOfQueueTypes; ++i)
+        {
             testCase(i);
+        }
     }
 
     // if a new fifo type is added this variable has to be adjusted