-
Notifications
You must be signed in to change notification settings - Fork 7
Development team values
Erik Hetzner edited this page Apr 2, 2018
·
2 revisions
-
All hands on deck for large PRs when they are ready so that the author isn't forced to continually rebase while the PR is awaiting review.
-
Add unit tests when you touch a file (leave it better than you found it).
-
If you find yourself on work that will generate a large PR, start to pull others in so that the PR isn't intimidating and others can contribute to follow on work.
-
Add performance awareness to your review process.
-
Nominate reviewers for things that look to be large PRs before they start.
-
When creating large PRs, consider if it should be 2 or more. Especially if driven by multiple JIRA tickets.
-
Announce important bug fixes loudly so that rebases can happen and the code can get to review apps in a more timely fashion