feat: add universal router #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i implemented full universal router types here https://github.com/banteg/universal-router/blob/master/uniswap/universal_router.py they are also fully covered by tests. would be nice to collab on finishing this |
Co-authored-by: fubuloubu <[email protected]>
antazoey
approved these changes
Jun 10, 2024
| PACKAGE_FOLDER = Path(__file__).parent.parent / "uniswap_sdk" | ||
|
|
||
|
|
||
| def clean_contract_type(contract_type): |
| "method_identifiers", | ||
| } | ||
| ) | ||
| return ContractType.model_validate(clean_model_dict) |
There was a problem hiding this comment.
model_copy() may also be an option here, however it doesn't seem like it comes with an exclude=
|
Do we want to fix the README Usage section? |
Sure, go for it |
johnson2427
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: APE-1783
How I did it
How to verify it
Checklist