feat(worker): add SILVERBACK_FORK_MODE handler execution context #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
force-pushed
the
feat/fork-mode
branch
from
fa70a1a
to
a4efe87
Compare
johnson2427
previously approved these changes
Oct 28, 2024
|
Going to give it a shot with ApeWorX/ape#2349 after removing the Lock |
fubuloubu
force-pushed
the
feat/fork-mode
branch
from
a13b45e
to
5dc3025
Compare
johnson2427
approved these changes
Oct 28, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR adds a settings mode to silverback to trigger every single registered handler (through the default registration interface) using a fork context (e.g.
with ape.networks.fork(): ...). This potentially unblocks theBacktestRunnerandsilverback testby allowing all tests to execute within a fork context off of historical stateHow I did it
depends: ApeWorX/ape#2349
How to verify it
Checklist
- [ ] New test cases have been added and are passing