generated from ApeWorX/project-template
-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure stable and latest releases are properly built #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
previously approved these changes
Oct 10, 2024
johnson2427
changed the title
fix: ensure stable and latest releases are properly built
Draft: fix: ensure stable and latest releases are properly built
Oct 10, 2024
fubuloubu
changed the title
Draft: fix: ensure stable and latest releases are properly built
fix: ensure stable and latest releases are properly built
Oct 10, 2024
fubuloubu
previously approved these changes
Oct 10, 2024
fubuloubu
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The way we currently push a container ensures that we are always behind by a release. This works fine for stable releases, but if we want latest releases to test newest changes, we have to install from the wheel correctly. The new Dockerfile ensures we are able to do so. I also updated the workflow to ensure we release the stable and latest releases correctly.
fixes: #130
fixes: SBK-574
How I did it
I moved the current Dockerfile to Dockerfile.stable, then copied most of the current Dockerfile and forced the install of the wheel that is sitting in the wheels folder.
How to verify it
You should see the new note pop up. Originally, this was not able to update
Checklist