Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure stable and latest releases are properly built #131

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

johnson2427
Copy link
Contributor

@johnson2427 johnson2427 commented Oct 10, 2024

What I did

The way we currently push a container ensures that we are always behind by a release. This works fine for stable releases, but if we want latest releases to test newest changes, we have to install from the wheel correctly. The new Dockerfile ensures we are able to do so. I also updated the workflow to ensure we release the stable and latest releases correctly.

fixes: #130
fixes: SBK-574

How I did it

I moved the current Dockerfile to Dockerfile.stable, then copied most of the current Dockerfile and forced the install of the wheel that is sitting in the wheels folder.

How to verify it

# Add a note to any of the local commands ex. `run`
docker build -t silverback:latest .
docker run silverback:latest --help

You should see the new note pop up. Originally, this was not able to update

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

Copy link

linear bot commented Oct 10, 2024

fubuloubu
fubuloubu previously approved these changes Oct 10, 2024
@johnson2427 johnson2427 changed the title fix: ensure stable and latest releases are properly built Draft: fix: ensure stable and latest releases are properly built Oct 10, 2024
@fubuloubu fubuloubu marked this pull request as draft October 10, 2024 16:00
@fubuloubu fubuloubu changed the title Draft: fix: ensure stable and latest releases are properly built fix: ensure stable and latest releases are properly built Oct 10, 2024
@johnson2427 johnson2427 marked this pull request as ready for review October 10, 2024 17:52
fubuloubu
fubuloubu previously approved these changes Oct 10, 2024
@johnson2427 johnson2427 merged commit 854919f into main Oct 10, 2024
22 checks passed
@johnson2427 johnson2427 deleted the fix/ghcr-release branch October 10, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: the build of the dockerfile is not correct
2 participants