refactor(platform): updates to StreamInfo and ClusterInfo models #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubuloubu
force-pushed
the
refactor/platform-models
branch
from
4ed1cd3
to
b419e12
Compare
fubuloubu
force-pushed
the
refactor/platform-models
branch
from
e77e421
to
b00613d
Compare
johnson2427
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
HMAC calc was backwards, added StreamInfo type so that Platform can just tell cli users how to pay for their clusters, adding
ClusterInfo.expirationto tell cli users when their clusters expireHow I did it
How to verify it
Checklist
- [ ] Documentation has been updated