Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where always warned #164

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jan 5, 2024

What I did

Issue where would always warn after installing because of hash suffix.

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey requested a review from fubuloubu January 5, 2024 23:35
@antazoey
Copy link
Member Author

antazoey commented Jan 5, 2024

you can see the problems in ape-solidity CI output:

tests/test_compiler.py::test_compile[SpacesInPragma]
tests/test_compiler.py::test_compile_missing_version
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.8.23+commit.f704f362, expecting v0.8.23
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.8.12+commit.f00d7308, expecting v0.8.12
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.8.14+commit.80d49f37, expecting v0.8.14
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.5.16+commit.9c3226ce, expecting v0.5.16
    warnings.warn(

tests/test_compiler.py::test_compile[SpacesInPragma]
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.4.26+commit.4563c3fc, expecting v0.4.26
    warnings.warn(

tests/test_compiler.py::test_compile_solc_not_installed
  /opt/hostedtoolcache/Python/3.11.7/x64/lib/python3.11/site-packages/solcx/install.py:714: UnexpectedVersionWarning: Installed solc version is v0.6.12+commit.27d51765, expecting v0.6.12
    warnings.warn(

(https://github.com/ApeWorX/ape-solidity/actions/runs/7426784048/job/20211201532)

Copy link

github-actions bot commented Feb 5, 2024

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 5, 2024
@antazoey antazoey merged commit 8136179 into ApeWorX:main Feb 5, 2024
17 checks passed
@antazoey antazoey deleted the fix/over-warning branch February 5, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants