test: rerun random URL connection test if need-be #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Had a CI failure but the URL was actually fine, just was offline for a split second or something.
How I did it
pytest-rerunfailures plugin
NOTE: Personally, plugins like this are a slippery slope and I think they should be avoided. If someone uses
flakeymarkers, I will likely object and poke. However, in this situation, it makes sense because it involves an outside URL; I think that element really makes this test rich so I'd like to keep it, but ya it should be considered flakey since it is outside of our control.How to verify it
CI doesnt fail now.
Checklist