refactor: move LOCAL_NETWORK_NAME to utils #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
force-pushed
the
refactor/local-net-const
branch
from
a5efd4b
to
18e290a
Compare
bitwise-constructs
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This avoid loading api modules before they are needed.
It is more likely utils are already loaded by this point so it is averagly better to import from here.
Also removed the import from registration as those files / logics need to be as fast as possible
All part of #2333
Trying to make the diff easier
How I did it
How to verify it
from ape.api.networks import LOCAL_NETWORK_NAMEshould still work btw so we dont breakChecklist