Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'nonce too low' errors during testing #2270

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Sep 9, 2024

What I did

probably another result of bad perfs, but we still need to await for nonces to increase when req confs is 0.
I added a test to ensure this doesnt break again.
Also added .confirmed property to receipt which is going to be useful later.
problems were rather anomalous but putting back 1 RPC call aint the end of the world

How I did it

  • put back nonce-await at top of method
  • del comment
  • add test
  • use helper methods to pot. allow providers to make their own receipts with differing behavior

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey marked this pull request as ready for review September 9, 2024 17:21
@antazoey antazoey merged commit 047b853 into ApeWorX:main Sep 9, 2024
16 checks passed
@antazoey antazoey deleted the fix/still-wait-for-nonce branch September 9, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants