Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ValueError: Unknown level: 'LOGLEVEL.WARNING' #2249

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Aug 27, 2024

What I did

Fix the bug in 3 spots because am mad:

  • Handle stringified LogLevel values with LogLevel prefix everywhere
  • Use .value in ape test because is more performant and makes more sense and you don't run into weird issues in some CI/CD environments.
  • Validate pytest args by excluding Ape's usage of -v (in case it is ending up in there)

How to verify it

ApeWorX/ApePay#99

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

fubuloubu
fubuloubu previously approved these changes Aug 27, 2024
@antazoey
Copy link
Member Author

so this didn't fix it yet! but no worries, trying something else

@antazoey
Copy link
Member Author

OK verified the bug is fixed. stomped out of existence.

@antazoey antazoey merged commit 4ff4a39 into ApeWorX:main Aug 27, 2024
18 checks passed
@antazoey antazoey deleted the fix/debug-str-err branch August 27, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants