Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the dependency manager accessible on ManagerAccessMixin #2233

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

antazoey
Copy link
Member

What I did

I noticed when trying to manager global dependencies in python, it can be awkward referencing the local project to do this.
this makes it less awkward.

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other places where this would be useful?

@antazoey
Copy link
Member Author

Are there other places where this would be useful?

I don't think so, most everything uses the ManagerAccessMixin, so this basically fixes it all in 1 spot!

@antazoey antazoey merged commit b6216a5 into ApeWorX:main Aug 22, 2024
16 checks passed
@antazoey antazoey deleted the feat/dm-access branch August 22, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants