fix: issue where Ape tries starting geth-dev for custom networks w/o URIs #2140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
i forgot to specify a URI for my custom network and nothing was in evmchains yet and i noticed Ape went ahead and tried starting a geth dev for me with this , and that wouldnt really work.
this PR makes it so Ape only uses default localhost URI if nothing is configured AND we are in a dev-net (local or fork).
How I did it
check
.is_dev
before using DEFAULT_SETTINGSHow to verify it
make a config like:
try launching geth
before it would try geth dev because it couldnt find any URI.
but now it fails because it knows you are not using a dev net and there is no Uri
Checklist