Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue where Ape tries starting geth-dev for custom networks w/o URIs #2140

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

antazoey
Copy link
Member

What I did

i forgot to specify a URI for my custom network and nothing was in evmchains yet and i noticed Ape went ahead and tried starting a geth dev for me with this , and that wouldnt really work.

this PR makes it so Ape only uses default localhost URI if nothing is configured AND we are in a dev-net (local or fork).

How I did it

check .is_dev before using DEFAULT_SETTINGS

How to verify it

make a config like:

networks:
  custom:
    - name: mainnet
      chain_id: 109
      ecosystem: shibarium
      base_ecosystem_plugin: polygon
      default_provider: node

try launching geth

before it would try geth dev because it couldnt find any URI.
but now it fails because it knows you are not using a dev net and there is no Uri

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@antazoey antazoey merged commit 941fb4f into ApeWorX:main Jun 14, 2024
15 checks passed
@antazoey antazoey deleted the fix/only-launch-geth-if-is-dev branch June 14, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants