Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upstream provider and forked network tools [APE-1485] #1714

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Oct 31, 2023

What I did

realizing it was absolute pain to need to do anything with the upstream provider, even at the plugin level.
This aids that by adding properties and such to a new class for forked networks and a method for getting that context as well.

  • show case in ape-safe and ape-foundry
  • update in all ecosystem plugins

How I did it

How to verify it

Checklist

  • All changes are completed
  • New test cases have been added
  • Documentation has been updated

@vany365 vany365 changed the title feat: upstream provider tools feat: upstream provider tools [APE-1485] Oct 31, 2023
@antazoey antazoey force-pushed the feat/upstream-provider-tools branch 2 times, most recently from 9aaf4e7 to 9d6d0bd Compare October 31, 2023 17:56
@antazoey antazoey changed the title feat: upstream provider tools [APE-1485] feat: upstream provider and forked network tools [APE-1485] Oct 31, 2023
@antazoey antazoey marked this pull request as ready for review October 31, 2023 19:21
fubuloubu
fubuloubu previously approved these changes Oct 31, 2023
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this

src/ape/api/networks.py Show resolved Hide resolved
@antazoey
Copy link
Member Author

antazoey commented Nov 1, 2023

I addressed feedback and need to merge because my I need for other work and is hard to manage without!
If more feedback arises, please let me know :)

@antazoey antazoey merged commit beb115b into ApeWorX:main Nov 1, 2023
15 checks passed
@antazoey antazoey deleted the feat/upstream-provider-tools branch November 1, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants