chore: bump click [APE-1212] #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vany365
changed the title
|
i belieb we need this one first ApeWorX/evm-trace#46 |
|
py-evm is still not allowing mypy >= 1.0 |
antazoey
changed the title
antazoey
force-pushed
the
chore/click-fix
branch
from
70b64d4
to
cdb3ca6
Compare
antazoey
force-pushed
the
chore/click-fix
branch
from
cdb3ca6
to
47f4858
Compare
antazoey
commented
Jul 20, 2023
| # ** Dependencies maintained by ApeWorX ** | ||
| "eip712>=0.2.1,<0.3", | ||
| "ethpm-types>=0.5.3,<0.6", | ||
| "evm-trace>=0.1.0a21", | ||
| "evm-trace==0.1.0a21", |
There was a problem hiding this comment.
once the new py-evm, eth-tester, and web3 are all released, we can fix this, as well officially bump mypy in the 1.0 range, holy moly! This is the best we can do for now - it allows it work with both envs if you know what you are doing but CI won't use 1.0 yet in its checks. Locally, both versions of mypy are happy (along with the changes in this PR). Sorry, it got a little whack, but we have some projects using > 1.0 and some are not and everything needs Ape in some capacity
fubuloubu
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I think we are finally able to do this.
For sure click, we will see if mypy works in CI
How I did it
How to verify it
Checklist