Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issues with 0.4 imports #122

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jul 2, 2024

What I did

fixes: issue where couldn't import from root of project in non-relative manner
fixes: issue with ethereum builtin namespace imports

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as ready for review July 2, 2024 18:45
@@ -1,12 +1,12 @@
# @version ^0.3.3

# Import a local interface.
import interfaces.IFace as IFace
from .interfaces import IFace as IFace
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was only working because of a weird glitch with non-local projects, as the test uses.
To ensure testing makes sense, I added an integration test to test_cli.py which uses the local project

@antazoey antazoey requested a review from fubuloubu July 2, 2024 20:05
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vyper namespace broke apart in 0.4, I think most migrated to ethereum but there might be 1-2 others

@antazoey
Copy link
Member Author

antazoey commented Jul 2, 2024

vyper namespace broke apart in 0.4, I think most migrated to ethereum but there might be 1-2 others

ive seen projects use both!

@antazoey antazoey merged commit e2636e1 into ApeWorX:main Jul 2, 2024
11 checks passed
@antazoey antazoey deleted the fix/vyper04issues branch July 2, 2024 20:44
@fubuloubu
Copy link
Member

fubuloubu commented Jul 2, 2024

vyper namespace broke apart in 0.4, I think most migrated to ethereum but there might be 1-2 others

ive seen projects use both!

I asked charles if there were other new ones introduced in 0.4 but i dont think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants