-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: issues with 0.4 imports #122
Conversation
@@ -1,12 +1,12 @@ | |||
# @version ^0.3.3 | |||
|
|||
# Import a local interface. | |||
import interfaces.IFace as IFace | |||
from .interfaces import IFace as IFace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was only working because of a weird glitch with non-local projects, as the test uses.
To ensure testing makes sense, I added an integration test to test_cli.py which uses the local project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vyper
namespace broke apart in 0.4, I think most migrated to ethereum
but there might be 1-2 others
ive seen projects use both! |
I asked charles if there were other new ones introduced in 0.4 but i dont think so |
What I did
fixes: issue where couldn't import from root of project in non-relative manner
fixes: issue with ethereum builtin namespace imports
How I did it
How to verify it
Checklist