Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use api to set confirmations on the tx after adding more #38

Merged
merged 2 commits into from
Mar 5, 2024
Merged

fix: use api to set confirmations on the tx after adding more #38

merged 2 commits into from
Mar 5, 2024

Conversation

antazoey
Copy link
Member

What I did

this ensures they are right and doesnt require anything weird

fixes: #35

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey marked this pull request as ready for review February 27, 2024 21:49
@fubuloubu fubuloubu merged commit eddc804 into ApeWorX:main Mar 5, 2024
13 checks passed
@antazoey antazoey deleted the fix/confs branch March 5, 2024 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ape safe pending approve fails if transaction is fully confirmed before executing
2 participants
@antazoey @fubuloubu