Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Fantom support #83

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

z80dev
Copy link
Contributor

@z80dev z80dev commented Oct 4, 2024

Alchemy supports Fantom now

What I did

Added support for Fantom mainnet and testnet

How I did it

Added Fantom opera and testnet to the list of supported networks

Added Fantom url format strings

Added logic for replacing "opera" with "mainnet" when formatting the URL

How to verify it

ape console --network fantom:mainnet:alchemy

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

antazoey
antazoey previously approved these changes Oct 25, 2024
Copy link
Member

@antazoey antazoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nits

README.md Outdated Show resolved Hide resolved
ape_alchemy/provider.py Show resolved Hide resolved
@antazoey
Copy link
Member

antazoey commented Oct 25, 2024

Integration tests are failing. Can you add ape-fantom to the test-dependencies. The tests pass if the plugin is installed.

Edit: done

@antazoey antazoey merged commit 19b6536 into ApeWorX:main Oct 25, 2024
5 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants