len: support len-len and value-len cases #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e2e1092.
Pull Request Test Coverage Report for Build 11878576917Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ccoVeille
reviewed
Nov 17, 2024
| ``` | ||
|
|
||
| **Autofix**: true. <br> | ||
| **Enabled by default**: true. <br> | ||
| **Reason**: More appropriate `testify` API with clearer failure message. | ||
|
|
||
| > [!CAUTION] | ||
| > The checker ignores assertions in which length checking is not a priority, e.g. |
There was a problem hiding this comment.
Maybe a link to the issue where the reason are provided could help people to understand it's normal, and it would be a bad thing to change
There was a problem hiding this comment.
This link would be the best I think
ccoVeille
reviewed
Nov 17, 2024
| // | ||
| // The checker ignores assertions in which length checking is not a priority, e.g | ||
| // | ||
| // assert.Equal(t, len(arr), value) |
There was a problem hiding this comment.
I would add it in the code, but I'm unsure about the exact line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #166