empty: add type conversions cases

Antonboom · Nov 17, 2024 · 39cb0f6 · 39cb0f6
1 parent e19e926
commit 39cb0f6
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 13 deletions.
diff --git a/analyzer/testdata/src/checkers-default/empty/empty_test.go b/analyzer/testdata/src/checkers-default/empty/empty_test.go
diff --git a/analyzer/testdata/src/checkers-default/empty/empty_test.go.golden b/analyzer/testdata/src/checkers-default/empty/empty_test.go.golden
@@ -100,12 +100,14 @@ func TestEmptyChecker_LenVarIndependence(t *testing.T) {
 		ch     chan int
 	)
 
-	assert.Empty(t, arr)    // want "empty: use assert\\.Empty"
-	assert.Empty(t, arrPtr) // want "empty: use assert\\.Empty"
-	assert.Empty(t, sl)     // want "empty: use assert\\.Empty"
-	assert.Empty(t, mp)     // want "empty: use assert\\.Empty"
-	assert.Empty(t, str)    // want "empty: use assert\\.Empty"
-	assert.Empty(t, ch)     // want "empty: use assert\\.Empty"
+	assert.Empty(t, arr)         // want "empty: use assert\\.Empty"
+	assert.Empty(t, arrPtr)      // want "empty: use assert\\.Empty"
+	assert.Empty(t, sl)          // want "empty: use assert\\.Empty"
+	assert.Empty(t, mp)          // want "empty: use assert\\.Empty"
+	assert.Empty(t, str)         // want "empty: use assert\\.Empty"
+	assert.Empty(t, []byte(str)) // want "empty: use assert\\.Empty"
+	assert.Empty(t, string(str)) // want "empty: use assert\\.Empty"
+	assert.Empty(t, ch)          // want "empty: use assert\\.Empty"
 }
 
 func TestEmptyChecker_Ignored(t *testing.T) {

diff --git a/internal/testgen/gen_empty.go b/internal/testgen/gen_empty.go
@@ -39,7 +39,7 @@ func (g EmptyTestsGenerator) TemplateData() any {
 	}{
 		CheckerName: CheckerName(checker),
 		LenTest: lenTest{
-			Vars:  []string{"arr", "arrPtr", "sl", "mp", "str", "ch"},
+			Vars:  []string{"arr", "arrPtr", "sl", "mp", "str", "[]byte(str)", "string(str)", "ch"},
 			Assrn: Assertion{Fn: "Equal", Argsf: "0, len(%s)", ReportMsgf: report, ProposedFn: "Empty", ProposedArgsf: "%s"},
 		},
 		Tests: []test{