Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data can be downloaded directly from data.gouv.fr/ #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vinraspa
Copy link

I use vacances-scolaires-france inside an app that is bundled with PyInstaller.
So I need data to be refreshed from year to year without updating vacances-scolaires-france module.
I added the possibility to ask for download the most recent data when the main class is initialized.
These modifications are backward compatible as reading from data/data.csv is kept as the default behavior.

@vinraspa
Copy link
Author

vinraspa commented Jun 13, 2022

I have no idea what the problem is with test-latest...
See this: xlcnd/isbnlib#95 (Nose is incompatible with Python >= 3.10)

@vinraspa
Copy link
Author

If this new feature is OK, I will create a new cleaner PR with an only one commit.
Otherwise, we can imagine not to deal with the download part of the job and just give the user the opportunity to supply their own csv file (requests module will ne be necessary anymore)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant