-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Index and order - qdb - lcia #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
index-and-order is not properly part of xdb, that is data management. so that stuff came out.
this thread introduces qdb as a separate router for eventual replacement /supplementation with a remote service
There also needs to be some way to test functionality wrt specific data sources.
WE STILL HAVEN'T DECIDED HOW TO MANAGE DATA SOURCES
this is a problem- but not for xdb
xdb syncs a directory structure- "AWS" is not even relevant. xdb has the content locally and it is ETL [e.g. dagster] to ensure necessary resources are provisioned.
then it runs. the only config is:
but nothing is tested.
Testing plan:
I don't know how to test the uvicorn server generally. but assuming it's up, the tests would be:
by route. what does the docs say?
here is a test client:
miguelgrinberg/python-socketio#332 (comment)
or better: https://stackoverflow.com/a/57816608
So, we test xdb locally, but we also need a data test. we have expectations of ecoinvent 3.6 vs 3.7; we have uslci; lists of expected-open resources generally. xdb is the first product and when it's live it's live. but that's a test of an Antelope service, not of xdb.