Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add oauth error_path #570

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Add oauth error_path #570

merged 1 commit into from
Nov 7, 2024

Conversation

comhar
Copy link
Contributor

@comhar comhar commented Nov 7, 2024


about: Handle OAuth Cancellations and Errors

Related Issue
#569

Proposed Changes
Update the OAuth redirect route so that it correctly handles oauth errors/cancellations.

In addition, this PR proposes an OAuth error_path parameter. The idea is that if the user hits cancel or some other error occurs, they will be redirected to error_path.

Types of changes
What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist
Go over all the following points, and put an x in all the boxes that apply:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I am aware that this is an nbdev project, and I have edited, cleaned, and synced the source notebooks instead of editing .py or .md files directly.

Additional Information
Any additional information, configuration or data that might be necessary to reproduce the issue.

Copy link

gitnotebooks bot commented Nov 7, 2024

Found 1 changed notebook. Review the changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/570

@comhar comhar added the bug Something isn't working label Nov 7, 2024
@comhar comhar requested a review from jph00 November 7, 2024 17:38
@johnowhitaker
Copy link
Contributor

Looks good to me.

@johnowhitaker johnowhitaker merged commit a206c06 into main Nov 7, 2024
2 checks passed
@johnowhitaker johnowhitaker deleted the handle-oauth-error branch November 7, 2024 18:34
@jph00 jph00 changed the title handle oauth error Add oauth error_path Nov 7, 2024
@jph00 jph00 added enhancement New feature or request and removed bug Something isn't working labels Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants