Skip to content

Commit

Permalink
# This is a combination of 3 commits.
Browse files Browse the repository at this point in the history
# This is the 1st commit message:

add type declaration for test-none-core-module

# This is the commit message #2:

Replaced cpx2 with a local module

# This is the commit message #3:

fixed lint errors
  • Loading branch information
Annosha committed Oct 19, 2024
1 parent 5efe104 commit 99ffb24
Show file tree
Hide file tree
Showing 8 changed files with 2,738 additions and 41 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"babel-loader": "8.4.1",
"babel-plugin-istanbul": "7.0.0",
"codecov": "3.8.3",
"cpx2": "2.0.0",

"cross-var": "1.1.0",
"karma": "6.4.4",
"karma-chrome-launcher": "3.1.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,10 @@ describe('RequireInTheMiddleSingleton', () => {
'codecov/lib/codecov.js',
onRequireCodecovLibStub
);
requireInTheMiddleSingleton.register('test-non-core-module', onRequireCpxStub);
requireInTheMiddleSingleton.register(
'test-non-core-module',
onRequireCpxStub
);
requireInTheMiddleSingleton.register(
'test-non-core-module/lib/copy-sync.js',
onRequireCpxLibStub
Expand Down Expand Up @@ -120,8 +123,12 @@ describe('RequireInTheMiddleSingleton', () => {

describe('non-core module', () => {
describe('AND module name matches', () => {
const baseDir = path.normalize(path.dirname(require.resolve('codecov')));
const modulePath = path.normalize(path.join('codecov', 'lib', 'codecov.js'));
const baseDir = path.normalize(
path.dirname(require.resolve('codecov'))
);
const modulePath = path.normalize(
path.join('codecov', 'lib', 'codecov.js')
);
it('should call `onRequire`', () => {
const exports = require('codecov');
assert.deepStrictEqual(exports.__ritmOnRequires, ['codecov']);
Expand Down Expand Up @@ -149,11 +156,15 @@ describe('RequireInTheMiddleSingleton', () => {

describe('non-core module with sub-path', () => {
describe('AND module name matches', () => {
const baseDir = path.normalize(path.resolve(
path.dirname(require.resolve('test-non-core-module')),
'..'
));
const modulePath = path.normalize(path.join('test-non-core-module', 'lib', 'copy-sync.js'));
const baseDir = path.normalize(
path.resolve(
path.dirname(require.resolve('test-non-core-module')),
'..'
)
);
const modulePath = path.normalize(
path.join('test-non-core-module', 'lib', 'copy-sync.js')
);
it('should call `onRequire`', () => {
const exports = require('test-non-core-module/lib/copy-sync');
assert.deepStrictEqual(exports.__ritmOnRequires, [
Expand All @@ -162,7 +173,12 @@ describe('RequireInTheMiddleSingleton', () => {
]);
sinon.assert.calledWithMatch(
onRequireCpxStub,
{ __ritmOnRequires: ['test-non-core-module', 'test-non-core-module-lib'] },
{
__ritmOnRequires: [
'test-non-core-module',
'test-non-core-module-lib',
],
},
modulePath,
baseDir
);
Expand Down

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 99ffb24

Please sign in to comment.