ci: adjust paths filter for tests, add new test case

Animechan-API · Aug 25, 2024 · 69abd24 · 69abd24
1 parent 3a4c04b
commit 69abd24
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -3,11 +3,14 @@ name: Tests
 on:
   push:
     branches: [main]
+    paths:
+      - 'server/**/*.ts'
+      - 'server/test/**'
   pull_request:
     branches: [main]
-  paths:
-    - 'server/**/*.ts'
-    - 'server/test/**'
+    paths:
+      - 'server/**/*.ts'
+      - 'server/test/**'
 
 jobs:
   build:

diff --git a/server/test/auth.test.ts b/server/test/auth.test.ts
@@ -12,10 +12,6 @@ test("Should pass on protected API urls", () => {
 	expect(isProtectedEndpoint(`${BASE_PATH}quotes?character=naruto`)).toBeTruthy();
 	expect(isProtectedEndpoint(`${BASE_PATH}quotes/?anime=naruto`)).toBeTruthy();
 	expect(isProtectedEndpoint(`${BASE_PATH}quotes/?character=naruto`)).toBeTruthy();
-
-	// Accepts additional not pre-defined params like `foo` here but only in the presence
-	// of a premium query param which is `character` in this case below.
-	expect(isProtectedEndpoint(`${BASE_PATH}quotes/random/?character=naruto&foo=bar`)).toBeTruthy();
 });
 
 test("should fail on unprotected/free API urls", () => {
@@ -36,3 +32,10 @@ test("Should pass on valid protected API urls with additional params", () => {
 		isProtectedEndpoint(`${BASE_PATH}quotes/random/?character=naruto&anime=naruto&page=2`),
 	).toBeTruthy();
 });
+
+test("Should pass on protected API urls with additional unknown params", () => {
+	// Accepts additional not pre-defined params like `foo` here but only in the presence
+	// of a premium query param which is `character` in this case below.
+	expect(isProtectedEndpoint(`${BASE_PATH}quotes/random/?character=naruto&foo=bar`)).toBeTruthy();
+	expect(isProtectedEndpoint(`${BASE_PATH}quotes/random/?foo=bar`)).toBeFalsy();
+});