Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix one of several USDImaging Nested Instancing Update Bugs #1

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

murphyeoin
Copy link

@murphyeoin murphyeoin commented Sep 17, 2019

Description of Change(s)

This is an attempted fix for https://groups.google.com/forum/#!topic/usd-interest/YPK05ebe8x4.
The most pared down examples of this are here:https://gist.github.com/murphyeoin/03637aaa39ced964e0d27cd207cc0b00

  • Disappointlingly, this does not fix either of the repros from this issue
  • I only understand a small amount of the code, so this fix is designed to minimise side-effects
  • we are testing it in production now (definitely needs some more work - currently getting Coding Error: in _ResyncInstancer at line 1213 of PLACEHOLDER/scratch/dev/AL_USD/usdImaging/pxr/usdImaging/lib/usdImaging/instanceAdapter.cpp – Failed verification: ' instIt != _instancerData.end() '
    in some circumstances)

Fixes Issue(s)

@murphyeoin murphyeoin changed the title basic attempt Attempt to fix one of several USDImaging Nested Instancing Update Bugs Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant