Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use query-string instead of manual query parsing #149

Merged
merged 1 commit into from
Oct 8, 2020

Conversation

rchl
Copy link
Contributor

@rchl rchl commented Oct 7, 2020

No description provided.

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@dc16939). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #149   +/-   ##
=========================================
  Coverage          ?   99.51%           
=========================================
  Files             ?       36           
  Lines             ?     1028           
  Branches          ?      282           
=========================================
  Hits              ?     1023           
  Misses            ?        2           
  Partials          ?        3           
Impacted Files Coverage Δ
src/loaders/postcss/url/resolve.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc16939...07dbaeb. Read the comment docs.

@Anidetrix
Copy link
Owner

Well that was fast, nice, LGTM!

@Anidetrix Anidetrix merged commit e85888a into Anidetrix:master Oct 8, 2020
@rchl rchl deleted the fix/query-params-2 branch October 8, 2020 09:34
@rchl
Copy link
Contributor Author

rchl commented Oct 8, 2020

👍
Any plans to make a release soon so that I can make use of this fix in my project? :)

@Anidetrix
Copy link
Owner

Finishing up with upgrading some packages (mostly PostCSS 8 migration), but plan to release right after that

@github-actions
Copy link

🎉 This PR is included in version 3.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants