Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PendingIntent.FLAG_IMMUTABLE flag for our intents #490

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

luk1337
Copy link
Member

@luk1337 luk1337 commented Oct 10, 2022

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • double-check your branch is based on develop and targets develop
  • Pull request has tests
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved
  • I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)

Description

This is required since we target Android 12+ API:
https://developer.android.com/guide/components/intents-filters#DeclareMutabilityPendingIntent

Motivation and Context

See #489

How Has This Been Tested?

Compile tested.

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

@wax911
Copy link
Member

wax911 commented Oct 10, 2022

Thanks @luk1337 💯

@wax911 wax911 added this to the 1.9.X milestone Oct 10, 2022
@wax911 wax911 merged commit 1df8132 into AniTrend:develop Oct 10, 2022
@wax911 wax911 linked an issue Oct 10, 2022 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android 12+ notification creation issue
2 participants