Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user specified Locale in BaseStatePageAdapter::setPagerTitles() #485

Conversation

luk1337
Copy link
Member

@luk1337 luk1337 commented Jul 21, 2022

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • double-check your branch is based on develop and targets develop
  • Pull request has tests
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved
  • I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)

Description

See: #483

Motivation and Context

See: #483

How Has This Been Tested?

Set your phone to Dutch, then set app language to anything but Dutch, notice that ViewPager titles are now correct.

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

This is a hacky solution for wrong ViewPager titles.

Closes: AniTrend#483
@luk1337
Copy link
Member Author

luk1337 commented Jul 21, 2022

Would be better if this hack wasn't necessary, b-but I have no idea how to make it work otherwise.

@wax911
Copy link
Member

wax911 commented Jul 21, 2022

Agreed! An actual fix well take a lot longer do we'll go with this for the time being

@wax911 wax911 changed the base branch from develop to hotfix/483-translations-not-being-applied-correctly July 22, 2022 14:47
@wax911 wax911 merged commit 3ac550d into AniTrend:hotfix/483-translations-not-being-applied-correctly Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants