Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use black navigation bar in black AMOLED theme #481

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

Br1ght0ne
Copy link
Contributor

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • double-check your branch is based on develop and targets develop
  • Pull request has tests
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved
  • I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)

Description

This changes the navbar of the black theme to match the theme, so it's better on AMOLED devices.
Supported on API v21+, so added overrides in values-v21.

Motivation and Context

Black theme uses a white navbar.

How Has This Been Tested?

Tested on API 17, API 21, API 32 emulators, on physical API 31 device.

Screenshots (if appropriate):

Before:
Screenshot_2022-05-31-12-23-30-667_com mxt anitrend

After:
Screenshot_2022-05-31-12-22-47-279_com mxt anitrend

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

Supported on API v21+, so added overrides in values-v21.
@wax911
Copy link
Member

wax911 commented Jun 2, 2022

Thanks for the PR @Br1ght0ne ❤️

@wax911 wax911 merged commit e66f9d8 into AniTrend:develop Jun 9, 2022
@Br1ght0ne Br1ght0ne deleted the amoled-black-navbar branch June 12, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants