Fix media activity crash on menu item visibility change #460
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AniTrend Pull Request
Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.
Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.
Before opening a pull request, please ensure:
develop
and targetsdevelop
Description
Fixes a crash that would happen when trying to access the
setManageMenuItemIcon
tosetMenuItemIcons
malMenuItem
intosetMenuItemIcons
and perform null-ability check on menu item prior to making any changesMotivation and Context
See linked issue.
How Has This Been Tested?
Checks
MenuItem
null-ability prior to making changesScreenshots (if appropriate):
n/a
Types of changes
IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.
Closes #458