Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOWNLOAD_LINK string format #452

Merged
merged 1 commit into from
Oct 26, 2021
Merged

Conversation

luk1337
Copy link
Member

@luk1337 luk1337 commented Oct 26, 2021

AniTrend Pull Request

Thank you for contributing! Please take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

Please open an issue before embarking on any significant pull request, especially those that
add a new library or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

Before opening a pull request, please ensure:

  • You have followed our contributing guidelines
  • double-check your branch is based on develop and targets develop
  • Pull request has tests
  • Code is well-commented, linted and follows project conventions
  • Documentation is updated (if necessary)
  • Description explains the issue/use-case resolved
  • I did not commit files that are excluded in the .gitignore file (Happens if you stage files with Android Studio)

Description

Every app release since v1.8.4 puts "-github" before "-release" thus the download link was invalid for github builds.

Motivation and Context

See description.

How Has This Been Tested?

Tried to download update.

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

IMPORTANT: By submitting a patch, you agree to allow the project
owners to license your work under the terms of the MIT License.

Every app release since v1.8.4 puts "-github" before "-release".
@luk1337
Copy link
Member Author

luk1337 commented Oct 26, 2021

@wax911 it'd probably be better to correct releases so that one can actually update from older builds. At least ones before this change, if you want to keep current naming scheme.

@wax911
Copy link
Member

wax911 commented Oct 26, 2021

@wax911 it'd probably be better to correct releases so that one can actually update from older builds. At least ones before this change, if you want to keep current naming scheme.

I think we can keep the new naming schema and indeed, we should update one of older builds just to allow others to update. So I can merge this PR if you give me the go ahead 💯

@luk1337
Copy link
Member Author

luk1337 commented Oct 26, 2021

Actually, it'd still be broken with newer naming scheme if someone is updating from build without this change to one with it...

@wax911 wax911 merged commit dfc95d0 into AniTrend:develop Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants