Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clipper.version.h getting dirty in windows #754

Closed
yoavmil opened this issue Dec 20, 2023 · 2 comments
Closed

clipper.version.h getting dirty in windows #754

yoavmil opened this issue Dec 20, 2023 · 2 comments

Comments

@yoavmil
Copy link

yoavmil commented Dec 20, 2023

This is a tiny request. I'm using windows. CMake at this line
configure_file(clipper.version.in ${CLIPPER2_INC_FOLDER}/clipper.version.h)
changes the file. It changes the endline style from unix to windows. To overcome it just do this
configure_file(clipper.version.in ${CLIPPER2_INC_FOLDER}/clipper.version.h NEWLINE_STYLE UNIX)
Cheers!

@AngusJohnson
Copy link
Owner

AngusJohnson commented Dec 21, 2023

I suggest that a better way of managing this (if it works 😜) is to change clipper.version.in to use unix style endlines.

Edit: Is this now fixed in the latest revision? (I can't test this as I don't currently have a linux OS installed.)

Edit2: Oops, I see now that, when committing revisions, git will ignore changes to endlines. So it looks like your suggestion above might be necessary after all. Nevertheless, why does it matter if clipper.version.h gets Windows endlines?

@yoavmil
Copy link
Author

yoavmil commented Dec 21, 2023

because git sees it a changed file, causing clipperlib to become dirty (thats how git calls it)

jiajuncccc added a commit to jiajuncccc/Clipper2 that referenced this issue Dec 22, 2023
* remotes/upstream/main:
  Minor tweak to CMakeLists.txt (AngusJohnson#754)
  Fixed a bug when offsetting, using delta callback, a path with a single point. (AngusJohnson#752) Minor code tidy (Delphi).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants