Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TPolyTree structure do difference with NonZero has wrong result in Delphi Clipper2Lib_1.2.3 #687

Closed
johnnyjohnnyjohnny opened this issue Oct 16, 2023 · 1 comment
Closed

TPolyTree structure do difference with NonZero has wrong result in Delphi Clipper2Lib_1.2.3 #687

johnnyjohnnyjohnny opened this issue Oct 16, 2023 · 1 comment

Comments

@johnnyjohnnyjohnny
Copy link

TClipType: ctDifference
TFillRule: frNonZero
SUBJECTS:
subject
Path1: (1500000, 1500000) (-1500000, 1500000) (-1500000, -1500000) (1500000, -1500000)
CLIPS:
clip
Path1: (1241598, 1224129) (-1258402, 1224129) (-1258402, -1275871) (1241598, -1275871)
Path2: (485123, -1207305) (485110, -1107366) (-292090, -330067) (-292090, 789878) (-559547, 1057362) (6719, 1057362) (108110, 955965) (108110, -163720) (108186, -164342) (885310, -941901) (885310, -1207305)
Path3: (578843, -923414) (731336, -923414) (12010, -204088) (12010, 873134) (11610, 882244) (10631, 889642) (-194671, 889642) (-194672, 889637) (-195721, 880601) (-195990, 873134) (-195990, -205026) (-99848, -205026) (-99848, -386386) (578843, -1065077)
EXPECT RESULT:
expect
ERROR RESULT:
error
@johnnyjohnnyjohnny johnnyjohnnyjohnny changed the title Doing difference with NonZero has wrong result in Delphi Clipper2Lib_1.2.3 TPolyTree structure do difference with NonZero has wrong result in Delphi Clipper2Lib_1.2.3 Oct 16, 2023
AngusJohnson added a commit that referenced this issue Oct 16, 2023
@AngusJohnson
Fixed a Delphi only bug in Polytree path ownership (#687)
6a7a401
@AngusJohnson
Copy link
Owner

Should be fixed now 🤞.

AngusJohnson added a commit that referenced this issue Nov 26, 2023
@AngusJohnson
Version 1.2.4
ff85874 
  Changes since ver 1.2.3 include:
  1. Important: Offsetting open path behaviour has changed.
     The delta now behaves as it did in Clipper1 (See Issue #707)
  2. Important: Data structures of exported values in clipper.export.h have changed.
  3. Minor bugfixes to PolyTree nesting (#679, #687)
  4. Numerous minor bugfixes to polygon offsetting (#703, #715, #724)
  5. Fixed an obscure bug in polygon clipping caused by horizontal spikes (#720)
  6. Significantly improved documentation.
jiajuncccc added a commit to jiajuncccc/Clipper2 that referenced this issue Dec 15, 2023
@jiajuncccc
Merge remote-tracking branch 'remotes/origin/main'
ddec95f 
* remotes/origin/main:
  Minor code tidy
  Added CLIPPER2_HI_PRECISION option in CMakeLists.txt
  Additional minor tweaks to cpp/benchmark tests
  Make googletest not be a git submodule, and instead clone it separately in the CI script (AngusJohnson#745)
  fix compiler warning of -Wunused-but-set-parameter with -fno-exceptions (AngusJohnson#744)
  Additional tweaks to GetIntersectPtBenchmark.cpp
  Additional GetIntersectPtBenchmark tweaks
  Fixed incorrect code comment
  Added new GetIntersectPoint benchmark test Updated other benchmark tests.
  Code formatting only (removed trailing spaces)
  Fixed minor typecasting issues (AngusJohnson#727)
  More tweaks to PointInPolygon benchmarking.
  Allow using external gtest with GTest:: qualified names (AngusJohnson#737)
  Fixed a significant (though uncommon) bug in polygon clipping (AngusJohnson#736) Fixed bugs in PointInPolygon benchmark testing.
  Minor tweaks to PointInPolygon benchmark testing.
  Fixed a minor syntax error tripping some C++ compilers
  Version 1.3.0 1. Fixed a significant offsetting bug introduced in previous update (AngusJohnson#733) 2. Fixed a C++ compile error when 32bit compiling (AngusJohnson#727) 3. Minor tweak to CMakeLists.txt (C++) (AngusJohnson#728) 4. Will now offset 'flat' polygons (Disc.AngusJohnson#725) 5. Reminder: recent change in open path offsetting behaviour (AngusJohnson#707) 6. Reminder: recent changes to clipper.export.h data structures.
  Fixed a typo and tweaked documentation
  Version 1.2.4   Changes since ver 1.2.3 include:   1. Important: Offsetting open path behaviour has changed.      The delta now behaves as it did in Clipper1 (See Issue AngusJohnson#707)   2. Important: Data structures of exported values in clipper.export.h have changed.   3. Minor bugfixes to PolyTree nesting (AngusJohnson#679, AngusJohnson#687)   4. Numerous minor bugfixes to polygon offsetting (AngusJohnson#703, AngusJohnson#715, AngusJohnson#724)   5. Fixed an obscure bug in polygon clipping caused by horizontal spikes (AngusJohnson#720)   6. Significantly improved documentation.
  Additional minor bugfix to ClipperOffset (AngusJohnson#724 & Disc.AngusJohnson#726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AngusJohnson @johnnyjohnnyjohnny