Unintended cast to bool?

[KarimLUCCIN]

Clipper2/CPP/Clipper2Lib/include/clipper2/clipper.h

Line 252 in 4057a50

return ExecuteRectClip(rect, PathsD{ line }, precision);

It looks like the line should be instead return ExecuteRectClip(rect, PathsD{ line }, false, precision);, otherwise it casts precision as a bool.

[AngusJohnson]

It looks like the line should be instead return ExecuteRectClip(rect, PathsD{ line }, false, precision);, otherwise it casts precision as a bool.

No, it should be returning ...
return ExecuteRectClipLines(rect, PathsD{ line }, precision);

[KarimLUCCIN]

I got a compiler warning on that line because for all of the possible overloads, it accepts a bool first for convex_only , and then a int for precision:

Clipper2/CPP/Clipper2Lib/include/clipper2/clipper.h

Line 216 in 4057a50

inline PathsD ExecuteRectClip(const RectD& rect,

Clipper2/CPP/Clipper2Lib/include/clipper2/clipper.h

Line 200 in 4057a50

inline Paths64 ExecuteRectClip(const Rect64& rect,

And so calling with PathsD{ line }, precision was casting precision into the convex_only parameter

[AngusJohnson]

Thanks for the feedback Karim.

I suspect my reply above was too brief and hence confusing.
The function I was referring to there was the following one:

  inline PathsD ExecuteRectClipLines(const RectD& rect, const PathD& line, int precision = 2)
  {
    return ExecuteRectClipLines(rect, PathsD{ line }, precision);
  }

If that was the function you amended, then I don't see why you'd be getting compiler errors now.
And there's no convex_only parameter in any of the overloaded ExecuteRectClipLines functions.

However, WRT ExecuteRectClip (ie not ExecuteRectClipLines), I can see that having 2 optional parameters where the second one can be implicitly cast to the first is asking for trouble, and is poor design. So I'm inclined to make the convex_only parameter no longer optional.