Add pretty printing for file size #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is fairly straightforward. The package 'filesize' is included as a lightweight method for converting a byte value into human readable form
|
Hello @JoshuaAF, Thank you for the PR. I checked the package. It doesn't have any external and the size is 2Kb so It's fine to include it in the library. Happy Hacktoberfest! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4
Added filesize package and line to convert the number of bytes to a more human readable form. If you would prefer to not add another dependency, let me know and I'd be willing to go with a different approach, but this is the most straightforward solution