UBUNTU: SAUCE: selftests: net: Don't fail test_vxlan_under_vrf on xfail

I changed the test for VXLAN underlay in non-default VRF to print XFAIL for expected failure, but the script still exits with an error which makes the test overall fail. Fix this to still exit successfully following the xfail. Signed-off-by: Seth Forshee <[email protected]>
AnetaCadova · Mar 4, 2019 · d3fb410 · d3fb410
1 parent 6ac68a8
commit d3fb410
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/tools/testing/selftests/net/test_vxlan_under_vrf.sh b/tools/testing/selftests/net/test_vxlan_under_vrf.sh
@@ -125,5 +125,8 @@ ip -netns hv-2 link set veth0 down
 ip -netns hv-2 link set veth0 up
 
 echo -n "Check VM connectivity through VXLAN (underlay in a VRF)            "
-ip netns exec vm-1 ping -c 1 -W 1 10.0.0.2 &> /dev/null || (echo "[XFAIL]"; false)
-echo "[ OK ]"
+if ! ip netns exec vm-1 ping -c 1 -W 1 10.0.0.2 &> /dev/null; then
+    echo "[XFAIL]"
+else
+    echo "[ OK ]"
+fi