fix: do not emit audioTrackRemove event upon jumping to a track #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
twlite
approved these changes
Apr 26, 2024
twlite
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added a boolean parameter named
emitEventwhich defaults to true for<GuildQueuePlayerNode>.jump.I ran into an issue, where I would like to jump to a track without it emitting the event
audioTrackRemove, I think that is a bug If it's not please let me know. This introduces a temporary fix for it. It can be modified to be extendable. It defaults to true, so the code doesn't break in other areas, so it's semi-optional not entirely but I don't know how to word it. It can be also changed from defaulting it to true, it being an optional parameter. It's dependent on how you want it to behave.Status