Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ discord.js v14 support #1210

Merged
merged 21 commits into from
Aug 4, 2022
Merged

✏️ discord.js v14 support #1210

merged 21 commits into from
Aug 4, 2022

Conversation

twlite
Copy link
Collaborator

@twlite twlite commented Jun 15, 2022

Changes

  • No major api changes. Old codes depending upon discord-player v5 should work just fine.
  • fixed channelEmpty
  • better initialVolume setter
  • other miscellaneous changes

@twlite
Copy link
Collaborator Author

twlite commented Jun 16, 2022

This version is now available at discord-player@dev:

$ npm install discord-player@dev

@igorwastaken
Copy link

I tried change now. And something is happening.
Bot can't find any songs.

@twlite twlite changed the title ✏️ discord-player v6 (discord.js v14 support) ✏️ discord.js v14 support Jul 19, 2022
@twlite twlite marked this pull request as ready for review July 19, 2022 14:17
@twlite
Copy link
Collaborator Author

twlite commented Jul 19, 2022

This update is now available on npm i [email protected]

@igorwastaken
Copy link

ty for letting us know!

Copy link
Owner

@Androz2091 Androz2091 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we keep examples? They're very useful when building a bot with the lib
otherwise seems great, going to be tested asap!

@twlite
Copy link
Collaborator Author

twlite commented Jul 20, 2022

Could we keep examples? They're very useful when building a bot with the lib otherwise seems great, going to be tested asap!

I used the discord-music-bot of yours to test this, how about using that (as a submodule)? Only needed to change the intents, everything else worked without any issues.

@ghost
Copy link

ghost commented Jul 20, 2022

Looks awesome, would love to see this merged.

@ghost
Copy link

ghost commented Jul 21, 2022

trackStart does not always fire for me from the testing I have done and songs aren't added to the queue when that happens. Pretty sure #1225 is a bug in this PR.

@twlite
Copy link
Collaborator Author

twlite commented Jul 21, 2022

I will look into this

@ghost
Copy link

ghost commented Jul 21, 2022

I will look into this

It seems to only happen some of the time and no errors of course, see if you can reproduce by restarting a few times and searching for songs.

@twlite
Copy link
Collaborator Author

twlite commented Jul 21, 2022

Landed some updates in [email protected]

@twlite twlite requested a review from Androz2091 July 21, 2022 15:14
@twlite twlite merged commit 42ef4d1 into master Aug 4, 2022
@twlite twlite deleted the next branch August 4, 2022 08:52
@twlite twlite restored the next branch August 4, 2022 08:52
@twlite twlite deleted the next branch August 4, 2022 09:29
@Bibyyy
Copy link

Bibyyy commented Aug 22, 2022

I tried change now. And something is happening. Bot can't find any songs.

hey, I had errors with an old version I updated to the latest version and the same thing happens to me, what can I do? My bot can't find sound via QueryType.AUTO whether it's a link or something...

@tm-frs
Copy link

tm-frs commented Aug 22, 2022

I tried change now. And something is happening. Bot can't find any songs.

hey, I had errors with an old version I updated to the latest version and the same thing happens to me, what can I do? My bot can't find sound via QueryType.AUTO whether it's a link or something...

This is a ytdl-core issue, discord-player can't do anything about it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment