Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YouTube copy at time & start from time #184

Closed
wants to merge 3 commits into from

Conversation

Yentis
Copy link

@Yentis Yentis commented Jul 18, 2024

  • Adds context menu button to youtube videos for copying at current time
  • Start youtube video from timestamp if available

Also tested and working on firefox

7mgQQ10frh

…, start youtube video from timestamp if available
@Andrews54757
Copy link
Owner

Good idea, but the implementation has some flaws.

  1. copy_clipboard should be validated such that non-fs sites can't arbitrary manipulate the clipboard
  2. The feature should work with other sources besides youtube
  3. Preferably should done without requiring extra permissions. Otherwise, justification will be needed in perms explainer page.

@Yentis
Copy link
Author

Yentis commented Jul 18, 2024

  1. I don't think this is a valid attack surface, any site can already write to the clipboard
  2. Why? The feature is only relevant to youtube, there's nothing I can implement for others

Andrews54757 added a commit that referenced this pull request Jul 31, 2024
@Andrews54757
Copy link
Owner

Andrews54757 commented Jul 31, 2024

Implemented using existing UI elements. Now you can click on the timestamp/duration label to copy a URL containing the timestamp. This works for other websites too. Simply paste in the sources browser to begin playing. Nevertheless, thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants