Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #156

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Fix typos #156

merged 3 commits into from
Jul 10, 2024

Conversation

lishaduck
Copy link
Contributor

Unfortunately, one leaked into the public api, necessitating a major.

Copy link

changeset-bot bot commented Jul 9, 2024

🦋 Changeset detected

Latest commit: 1859c47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
eslint-config-sheriff Major
@sherifforg/types Major
docs-website Patch
sheriff-webservices Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sheriff ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:25pm

@lishaduck
Copy link
Contributor Author

Docusaurus claims I broke a link, but I'm 99% sure it's wrong.

@lishaduck
Copy link
Contributor Author

lishaduck commented Jul 9, 2024

Oh, nope, it's right. 😅 I'll fix it! 🙃

@AndreaPontrandolfo
Copy link
Owner

Oh gosh, i have no idea how this did slip trough haha

@lishaduck
Copy link
Contributor Author

Oh gosh, i have no idea how this did slip trough haha

It's been like this the whole time, but I never got around to complaining 😆

@AndreaPontrandolfo
Copy link
Owner

I had Megalinter setup on CI but i had to disable it because it was too much noise.

@lishaduck
Copy link
Contributor Author

lishaduck commented Jul 9, 2024

I had Megalinter setup on CI but i had to disable it because it was too much noise.

Yeah. I've found running streetsidesoftware/cspell-action to be good at catching it instead, as I couldn't get megalinter to play nice with my ESLint config.

@AndreaPontrandolfo
Copy link
Owner

Yeah Cspell is integrated into Megalinter.
But again, it was too much work to keep up with.

I couldn't get megalinter to play nice with my ESLint config.

I simply disabled the Eslint part of Megalinter, as obviously i didn't need it.

@lishaduck
Copy link
Contributor Author

lishaduck commented Jul 9, 2024

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

.prettierignore Show resolved Hide resolved
@AndreaPontrandolfo
Copy link
Owner

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

What do you mean?

@lishaduck
Copy link
Contributor Author

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

What do you mean?

https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/#project-service

@AndreaPontrandolfo
Copy link
Owner

Oh, and I guess once we get typescript-eslint@8, then we could remove pathsOverrides in favor of using the projectService.

What do you mean?

https://typescript-eslint.io/blog/announcing-typescript-eslint-v8-beta/#project-service

I'll start a discussion so we can merge this in the meantime.

@AndreaPontrandolfo AndreaPontrandolfo merged commit 25a4855 into AndreaPontrandolfo:master Jul 10, 2024
3 checks passed
@AndreaPontrandolfo
Copy link
Owner

Discussion started here: #160

@lishaduck lishaduck deleted the typos branch July 11, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants