This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
Remove ETHERSCAN_API_KEY from Travis
#93
Labels
enhancement
New feature or request
Comments
AndreMiras
added a commit
that referenced
this issue
May 28, 2018
- makes the `ETHERSCAN_API_KEY` optional
- removes it from `.travis.yml` and `tox.ini` files
- updates Dockerfiles to workaround `travis_wait` issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Since everything (remote calls) is and should mocked anyway. We don't really need to pass the real API key via Travis from Docker then to Tox. It introduces a lot of levels of indirection and makes it hard to follow.
Also the API key is not really mandatory for making few requests in Etherscan anyway. So we could also make it easy for people checking out the code to play without having to provide a key. Therefore I would suggest to set some default key if the json file or env variable is not set. We could use the way provided in the Etherscan documentation i.e.
YourApiKeyToken. But write a warning to the console stating so.The text was updated successfully, but these errors were encountered: