Skip to content

Commit

Permalink
terminal: fix xterm opacity issue
Browse files Browse the repository at this point in the history
Fixes: eclipse-theia#8158

The following commit addresses an issue with newer versions of `xterm`
which displayed a secondary cursor-like border due to our global
`:focus` class. The fix updates the xterm textarea to force an opacity
consistent with their sources.

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto committed Jul 20, 2020
1 parent f4fe39e commit 4c63f08
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions packages/terminal/src/browser/style/terminal.css
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,9 @@
/* fix random 1px white border on terminal in Firefox. See https://github.com/eclipse-theia/theia/issues/4665 */
border: 1px solid var(--theia-terminal-background);
}


.terminal-container .xterm .xterm-helper-textarea {
/* fix secondary cursor-like issue. See https://github.com/eclipse-theia/theia/issues/8158 */
opacity: 0 !important;
}

0 comments on commit 4c63f08

Please sign in to comment.