Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure triggering sensor is included in alarm payload even when delay configured #39

Merged
merged 1 commit into from
Jul 18, 2022
Merged

Ensure triggering sensor is included in alarm payload even when delay configured #39

merged 1 commit into from
Jul 18, 2022

Conversation

sumnerboy12
Copy link
Contributor

Fixes #38

@sumnerboy12 sumnerboy12 mentioned this pull request Jul 9, 2022
Open
@sumnerboy12
Copy link
Contributor Author

@macinspak any chance we could get this merged?

@macinspak macinspak merged commit cdbc6b2 into Anamico:master Jul 18, 2022
@sumnerboy12 sumnerboy12 deleted the trigger_source_when_delayed branch July 18, 2022 00:46
@macinspak
Copy link
Contributor

Published as 1.3.0, please confirm all working for you guys.

Thanks for the PR and apologies for the delay.

@sumnerboy12
Copy link
Contributor Author

Happy to contribute - thanks for the great node!

@sumnerboy12
Copy link
Contributor Author

@macinspak I see that v1.3.0 is showing on npmjs but it is still only v1.2.5 on NodeRED.

How long does it take to update, or is there a manual step needed?

@macinspak
Copy link
Contributor

macinspak commented Jul 19, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delayed alarm not showing trigger source in payload.
2 participants
@sumnerboy12 @macinspak