Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paths for Mac and Linux #73

Merged
merged 7 commits into from
Dec 1, 2017
Merged

Fix paths for Mac and Linux #73

merged 7 commits into from
Dec 1, 2017

Conversation

emackey
Copy link
Member

@emackey emackey commented Dec 1, 2017

This changes handling of the file:/// protocol to be more platform-agnostic.

Before merging, I'm still holding for:

  • Today's release of Cesium 1.40, which contains fixes to joinUrls to support this (cesium#5989)
  • Should update CesiumView.js to use new Credits API (cesium#6005)

Fixes #58.

@emackey
Copy link
Member Author

emackey commented Dec 1, 2017

Tasks complete. Here it comes.

@emackey emackey merged commit b52706a into master Dec 1, 2017
@emackey emackey deleted the path-problems branch December 1, 2017 20:09
@michaelybecker
Copy link

Most excellent! Just in time for crunch time at work:)
Thanks again for your work on this - probably my most-used VSCode extension.

@emackey
Copy link
Member Author

emackey commented Dec 1, 2017

Published as 2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preview failing for Babylon and Cesium in MacOS
2 participants